statement-store: implement new rpc api #10690

alexggh · 2025-12-18T13:16:54Z

Work in progress

Description

Implements the proposed changes from here #10452, where the API surface has been limited to two functions submit and a subscribe_statement.

Submit changes

For submitting the only changes are implementing the logic of the newly expiry field where statements with an expiration timestamp lower than current time get rejected.

Subscribe changes

For subscription the approach is to have a configurable number of workers that keep track of all subscriptions, each time a new subscription arrives it gets assigned by a round-robin protocol to one of the workers.

When a new statements gets accepted by the statement-store it notifies all workers about the statement, the workers then go and evaluate all subscription filters they are assigned to and notifies each of them accordingly.

Remaining work

Add more tests.
Evaluate performance under load and port statement_store_bench.rs to using subscribe API, ported and performance stay the same on the benchmark, because bottlenecks are elsewhere and being addressed.

[2026-01-07T17:18:51Z INFO  tests::zombie_ci::statement_store_bench] Participants: 49998, each sent: 6, received: 0
[2026-01-07T17:18:51Z INFO  tests::zombie_ci::statement_store_bench] Summary        min       avg       max
[2026-01-07T17:18:51Z INFO  tests::zombie_ci::statement_store_bench]  time, s         8        19        24
[2026-01-07T17:18:51Z INFO  tests::zombie_ci::statement_store_bench]  retries         0         0         0

Evaluate and set proper RPC limits. The normal RPC limits apply here we just need to make sure RPC nodes run with limits high enough, so each user can connect to the node all at the same time.
Periodically scan existing statements and removed expired ones.
Plan for deploying it with minimising impact for people prototype with the old APIs
- This modifies statement format(expiry field), Runtime and Node need to run latest version.

Local testing

To obtain a local node with the new APIs available run:

cargo build -p polkadot -p polkadot-parachain-bin  --bin polkadot --bin polkadot-prepare-worker --bin polkadot-execute-worker --bin polkadot-parachain  --features fast-runtime;
 
ZOMBIE_PROVIDER=native cargo test -p cumulus-zombienet-sdk-tests --features zombie-ci zombie_ci::statement_store::statement_store

The rpc addresses are visible in the output:

charlie: direct link (pjs) https://polkadot.js.org/apps/?rpc=ws://127.0.0.1:26997#/explorer
dave: direct link (pjs) https://polkadot.js.org/apps/?rpc=ws://127.0.0.1:12623#/explorer

…e_dev --bump major'

Co-authored-by: Alexandru Gheorghe <[email protected]>

Signed-off-by: Alexandru Gheorghe <[email protected]>

…ne_shot_the_api

…dation

Signed-off-by: Alexandru Gheorghe <[email protected]>

…dation

Signed-off-by: Alexandru Gheorghe <[email protected]>

…dation

Signed-off-by: Alexandru Gheorghe <[email protected]>

paritytech-workflow-stopper · 2026-01-12T14:45:54Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/20922436110
Failed job name: cargo-clippy

Signed-off-by: Alexandru Gheorghe <[email protected]>

AndreiEres

Great work, Alex!
Looks good, left a few questions.

cumulus/parachains/runtimes/people/people-westend/src/lib.rs

substrate/primitives/statement-store/src/lib.rs

substrate/primitives/statement-store/src/store_api.rs

substrate/bin/node/rpc/src/lib.rs

substrate/client/statement-store/src/lib.rs

substrate/client/statement-store/src/subscription.rs

substrate/client/rpc/src/statement/mod.rs

s0me0ne-unkn0wn

I'm just skimming it for now. The API itself looks good and quite intuitive. I'm yet to understand the mechanics happening inside.

cumulus/parachains/runtimes/people/people-westend/src/lib.rs

P1sar · 2026-01-14T12:51:24Z

Closes: #10568, #10457

Signed-off-by: Alexandru Gheorghe <[email protected]>

AndreiEres · 2026-01-19T15:09:51Z

cumulus/zombienet/zombienet-sdk/tests/zombie_ci/statement_store.rs

+	log::info!("Statement store test passed");
+	log::info!("Keeping network alive");

+	tokio::time::sleep(Duration::from_hours(24)).await;


why we need hang the test for 24h?

It is there for App guys to have a node setup they can run locally, will remove it before merge.

AndreiEres · 2026-01-19T15:13:58Z

substrate/primitives/statement-store/src/store_api.rs

+	fn try_into(self) -> Result<CheckedTopicFilter> {
+		match self {
+			TopicFilter::Any => Ok(CheckedTopicFilter::Any),
+			TopicFilter::MatchAll(topics) => {


Should we check topics.len() <= 4?

AndreiEres · 2026-01-19T15:22:54Z

substrate/client/statement-store/src/lib.rs

 		let mut evicted = HashSet::new();
 		let mut would_free_size = 0;
-		let priority = Priority(statement.priority().unwrap_or(0));
+		let expiry = Expiry(statement.expiry());


why not statement.expiry() -> Expiry?

AndreiEres and others added 28 commits November 25, 2025 16:04

Extend submission result types

853a9df

Remove NetworkPriority (which was never used)

c6d8e87

Add Invalid result

1cc5ae9

Handle encoding_too_large

550d9fa

Add rejected variant

b153d0f

Update from github-actions[bot] running command 'prdoc --audience nod…

32b198b

…e_dev --bump major'

Update

31a606b

Update

bc77940

Update PR doc

67d915f

Fix PR doc

068364a

Update substrate/client/rpc-api/src/statement/mod.rs

4b6cc03

Co-authored-by: Alexandru Gheorghe <[email protected]>

Fix assertion

89c3c37

Don't copy types

a3a0a90

statement-store: api changes

534ec44

Signed-off-by: Alexandru Gheorghe <[email protected]>

Merge remote-tracking branch 'origin/AndreiEres/sss-rpc-types' into o…

b3d1b36

…ne_shot_the_api

Merge remote-tracking branch 'origin/master' into alexggh/api-consoli…

6ef12d3

…dation

remove replacement_preference_mask

af1be1d

Signed-off-by: Alexandru Gheorghe <[email protected]>

remove unused

c394914

Signed-off-by: Alexandru Gheorghe <[email protected]>

remove unused

3ad1478

Signed-off-by: Alexandru Gheorghe <[email protected]>

remove unused

31d3f53

Signed-off-by: Alexandru Gheorghe <[email protected]>

Merge remote-tracking branch 'origin/master' into alexggh/api-consoli…

03fcc46

…dation

address feedback

acf0103

Signed-off-by: Alexandru Gheorghe <[email protected]>

fixup documentation

65cd2ec

Signed-off-by: Alexandru Gheorghe <[email protected]>

fix documentation

e97cb8f

Signed-off-by: Alexandru Gheorghe <[email protected]>

remove non-api changes for now

eca03c7

Signed-off-by: Alexandru Gheorghe <[email protected]>

fix typos

f43fc81

Signed-off-by: Alexandru Gheorghe <[email protected]>

remove original api

849c17f

Signed-off-by: Alexandru Gheorghe <[email protected]>

statement-store: implement new api

dad2bd3

Signed-off-by: Alexandru Gheorghe <[email protected]>

alexggh mentioned this pull request Dec 19, 2025

[DRAFT] statement-store: re-defining RPC API surface #10452

Draft

update and use statement_store_bench

ec178a0

Signed-off-by: Alexandru Gheorghe <[email protected]>

alexggh added 4 commits January 8, 2026 12:15

send existing statements

af3d636

Signed-off-by: Alexandru Gheorghe <[email protected]>

added more tests

1ddc597

Signed-off-by: Alexandru Gheorghe <[email protected]>

bench configure connections properly

4138d92

Signed-off-by: Alexandru Gheorghe <[email protected]>

add periodical expiration of statements

fa73bd7

Signed-off-by: Alexandru Gheorghe <[email protected]>

alexggh changed the base branch from alexggh/api-consolidation to master January 8, 2026 15:39

alexggh changed the title ~~[DRAFT] statement-store: implement new api~~ statement-store: implement new rpc api Jan 8, 2026

alexggh marked this pull request as ready for review January 8, 2026 15:41

alexggh added 5 commits January 8, 2026 17:52

Merge remote-tracking branch 'origin/master' into alexggh/api-consoli…

54be894

…dation

make clippy happy

c157a26

Signed-off-by: Alexandru Gheorghe <[email protected]>

fix build

55b7c28

Signed-off-by: Alexandru Gheorghe <[email protected]>

Merge remote-tracking branch 'origin/master' into pr-10690

cf81c8a

make clippy happy

a7e65cd

Signed-off-by: Alexandru Gheorghe <[email protected]>

alexggh added the T0-node This PR/Issue is related to the topic “node”. label Jan 12, 2026

remove unused function

004f80b

Signed-off-by: Alexandru Gheorghe <[email protected]>

alexggh requested review from AndreiEres, P1sar and s0me0ne-unkn0wn January 12, 2026 15:28

AndreiEres reviewed Jan 12, 2026

View reviewed changes

s0me0ne-unkn0wn reviewed Jan 12, 2026

View reviewed changes

cumulus/parachains/runtimes/people/people-westend/src/lib.rs Outdated Show resolved Hide resolved

review feedback

4ec4df4

Signed-off-by: Alexandru Gheorghe <[email protected]>

AndreiEres approved these changes Jan 19, 2026

View reviewed changes

statement-store: implement new rpc api #10690

Are you sure you want to change the base?

statement-store: implement new rpc api #10690

Uh oh!

Conversation

alexggh commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Work in progress

Description

Submit changes

Subscribe changes

Remaining work

Local testing

Uh oh!

paritytech-workflow-stopper bot commented Jan 12, 2026

Uh oh!

AndreiEres left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

P1sar commented Jan 14, 2026

Uh oh!

AndreiEres Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

alexggh Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

AndreiEres Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

AndreiEres Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexggh commented Dec 18, 2025 •

edited

Loading